feat: create gyro E-CLP on v3 #570
Open
+1,045
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
reviewed
Mar 2, 2025
MattPereira
reviewed
Mar 2, 2025
MattPereira
reviewed
Mar 2, 2025
mkflow27
reviewed
Mar 3, 2025
MattPereira
reviewed
Mar 4, 2025
Draft
johngrantuk
commented
Mar 4, 2025
johngrantuk
commented
Mar 4, 2025
MattPereira
reviewed
Mar 5, 2025
Comment on lines
+326
to
+338
| // TODO: grow bigger brain to figure out param values that trigger InvariantDenominatorWrong | ||
| test.skip('InvariantDenominatorWrong()', async () => { | ||
| expect( | ||
| buildCallWithModifiedInput({ | ||
| eclpParams: { | ||
| s: _ONE, | ||
| }, | ||
| derivedEclpParams: { | ||
| u: _ONE_XP, | ||
| }, | ||
| }), | ||
| ).toThrowError( | ||
| `InvariantDenominatorWrong: mulDenominator must be <= ${_MAX_INV_INVARIANT_DENOMINATOR_XP}`, |
There was a problem hiding this comment.
If anyone thinks this is worth figuring out, I can spend more time on it, but kinda tricky with the derived params being calculated off chain by closed source code
There was a problem hiding this comment.
Also is it weird to have the validation tests in SDK repo but the logic in balancer maths?
MattPereira
reviewed
Mar 5, 2025
Comment on lines
+20
to
+26
| validateCreatePool(input: CreatePoolGyroECLPInput) { | ||
| super.validateCreatePool(input); | ||
|
|
||
| const { eclpParams, derivedEclpParams } = input; | ||
|
|
||
| GyroECLPMath.validateParams(eclpParams); | ||
| GyroECLPMath.validateDerivedParams(eclpParams, derivedEclpParams); |
There was a problem hiding this comment.
This was such a satisfying refactor 😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #571
Summary
TokenConfig[]type for thetokenspropertybalancer-mathsas dependency for gyro ELCP input validations